Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): Add telemetry on signals INTELLIJ-180 #119

Merged
merged 11 commits into from
Jan 17, 2025
Merged

Conversation

kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Jan 16, 2025

Description

Checklist

Open Questions

@kmruiz kmruiz self-assigned this Jan 16, 2025
@github-actions github-actions bot added the feat label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Coverage Report

Overall Project 79.39% -0.38%
Files changed 90.21%

File Coverage
FieldCheckInspectionBridge.kt 99.49%
TelemetryEvent.kt 96.08%
InspectionStatusChangedProbe.kt 94.39% -5.61%
DataGripMongoDbDriver.kt 94.06% -1.88% 🚫
AbstractMongoDbInspectionBridge.kt 92.22% -5.56% 🚫
IndexCheckInspectionBridge.kt 86.89%
NamespaceCheckInspectionBridge.kt 84.93% -7.12%
SpringAtQueryDialectParser.kt 30.4% -3.29% 🚫

@github-actions github-actions bot added feat and removed feat labels Jan 16, 2025
@kmruiz kmruiz force-pushed the feat/INTELLIJ-180 branch from 6e6b220 to cb7b558 Compare January 16, 2025 20:56
@github-actions github-actions bot added feat and removed feat labels Jan 16, 2025
@github-actions github-actions bot added feat and removed feat labels Jan 16, 2025
@github-actions github-actions bot added feat and removed feat labels Jan 16, 2025
@kmruiz kmruiz requested a review from himanshusinghs January 16, 2025 21:00
@github-actions github-actions bot added feat and removed feat labels Jan 16, 2025
@kmruiz kmruiz marked this pull request as ready for review January 16, 2025 21:42
@github-actions github-actions bot added feat and removed feat labels Jan 16, 2025
@github-actions github-actions bot removed the feat label Jan 16, 2025
@github-actions github-actions bot added the feat label Jan 16, 2025
@github-actions github-actions bot added feat and removed feat labels Jan 17, 2025
@github-actions github-actions bot added feat and removed feat labels Jan 17, 2025
@github-actions github-actions bot added feat and removed feat labels Jan 17, 2025
Copy link

🤖 Benchmark Comparison for chore: fail safe in case telemetry fails

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,600,565,477.62 ops/s 2,664,140,530.48 ops/s 2.44%

@github-actions github-actions bot added feat and removed feat labels Jan 17, 2025
Copy link

🤖 Benchmark Comparison for Merge branch 'main' into feat/INTELLIJ-180

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,668,742,126.31 ops/s 2,602,281,813.98 ops/s -2.49%

Copy link
Contributor

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work 🚀

@@ -206,8 +210,16 @@ internal class DataGripMongoDbDriver(

withTimeout(timeout) {
val listOfResults = mutableListOf<T>()
val resultSet = statement.executeQuery() ?: return@withTimeout emptyList()
val queryResult = runCatching { statement.executeQuery() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👁️

@kmruiz kmruiz merged commit 845d0dc into main Jan 17, 2025
11 checks passed
@kmruiz kmruiz deleted the feat/INTELLIJ-180 branch January 17, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants